368 lines
16 KiB
Python
368 lines
16 KiB
Python
|
# -*- coding: utf-8 -*-
|
||
|
|
# Part of Odoo. See LICENSE file for full copyright and licensing details.
|
||
|
|
import base64
|
||
|
|
import json
|
||
|
|
import os
|
||
|
|
|
||
|
|
from io import BytesIO
|
||
|
|
from zipfile import ZipFile
|
||
|
|
|
||
|
|
import odoo.tests
|
||
|
|
from odoo.tests import new_test_user
|
||
|
|
|
||
|
|
|
||
|
|
from unittest.mock import patch
|
||
|
|
|
||
|
|
from odoo import release
|
||
|
|
from odoo.addons import __path__ as __addons_path__
|
||
|
|
from odoo.tools import mute_logger
|
||
|
|
|
||
|
|
|
||
|
|
@odoo.tests.tagged('post_install', '-at_install')
|
||
|
|
class TestImportModule(odoo.tests.TransactionCase):
|
||
|
|
|
||
|
|
def import_zipfile(self, files):
|
||
|
|
archive = BytesIO()
|
||
|
|
with ZipFile(archive, 'w') as zipf:
|
||
|
|
for path, data in files:
|
||
|
|
zipf.writestr(path, data)
|
||
|
|
return self.env['ir.module.module']._import_zipfile(archive)
|
||
|
|
|
||
|
|
def test_import_zip(self):
|
||
|
|
"""Assert the behaviors expected by the module import feature using a ZIP archive"""
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"{'data': ['data.xml', 'res.partner.csv', 'data.sql']}"),
|
||
|
|
('foo/data.xml', b"""
|
||
|
|
<data>
|
||
|
|
<record id="foo" model="res.partner">
|
||
|
|
<field name="name">foo</field>
|
||
|
|
</record>
|
||
|
|
</data>
|
||
|
|
"""),
|
||
|
|
('foo/res.partner.csv',
|
||
|
|
b'"id","name"\n' \
|
||
|
|
b'bar,bar'
|
||
|
|
),
|
||
|
|
('foo/data.sql', b"INSERT INTO res_currency (name, symbol, active) VALUES ('New Currency', 'NCU', TRUE);"),
|
||
|
|
('foo/static/css/style.css', b".foo{color: black;}"),
|
||
|
|
('foo/static/js/foo.js', b"console.log('foo')"),
|
||
|
|
('bar/__manifest__.py', b"{'data': ['data.xml']}"),
|
||
|
|
('bar/data.xml', b"""
|
||
|
|
<data>
|
||
|
|
<record id="foo" model="res.country">
|
||
|
|
<field name="name">foo</field>
|
||
|
|
<field name="code">XX</field>
|
||
|
|
</record>
|
||
|
|
</data>
|
||
|
|
"""),
|
||
|
|
]
|
||
|
|
self.import_zipfile(files)
|
||
|
|
self.assertEqual(self.env.ref('foo.foo')._name, 'res.partner')
|
||
|
|
self.assertEqual(self.env.ref('foo.foo').name, 'foo')
|
||
|
|
self.assertEqual(self.env.ref('foo.bar')._name, 'res.partner')
|
||
|
|
self.assertEqual(self.env.ref('foo.bar').name, 'bar')
|
||
|
|
self.assertEqual(self.env['res.currency'].search_count([('symbol', '=', 'NCU')]), 1)
|
||
|
|
|
||
|
|
self.assertEqual(self.env.ref('bar.foo')._name, 'res.country')
|
||
|
|
self.assertEqual(self.env.ref('bar.foo').name, 'foo')
|
||
|
|
|
||
|
|
for path, data in files:
|
||
|
|
if path.split('/')[1] == 'static':
|
||
|
|
static_attachment = self.env['ir.attachment'].search([('url', '=', '/%s' % path)])
|
||
|
|
self.assertEqual(static_attachment.name, os.path.basename(path))
|
||
|
|
self.assertEqual(static_attachment.datas, base64.b64encode(data))
|
||
|
|
|
||
|
|
def test_import_zip_invalid_manifest(self):
|
||
|
|
"""Assert the expected behavior when import a ZIP module with an invalid manifest"""
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"foo")
|
||
|
|
]
|
||
|
|
with mute_logger("odoo.addons.base_import_module.models.ir_module"):
|
||
|
|
result = self.import_zipfile(files)
|
||
|
|
self.assertIn("Error while importing module 'foo'", result[0])
|
||
|
|
|
||
|
|
def test_import_zip_data_not_in_manifest(self):
|
||
|
|
"""Assert a data file not mentioned in the manifest is not imported"""
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"{'data': ['foo.xml']}"),
|
||
|
|
('foo/foo.xml', b"""
|
||
|
|
<data>
|
||
|
|
<record id="foo" model="res.partner">
|
||
|
|
<field name="name">foo</field>
|
||
|
|
</record>
|
||
|
|
</data>
|
||
|
|
"""),
|
||
|
|
('foo/bar.xml', b"""
|
||
|
|
<data>
|
||
|
|
<record id="bar" model="res.partner">
|
||
|
|
<field name="name">bar</field>
|
||
|
|
</record>
|
||
|
|
</data>
|
||
|
|
"""),
|
||
|
|
]
|
||
|
|
self.import_zipfile(files)
|
||
|
|
self.assertEqual(self.env.ref('foo.foo').name, 'foo')
|
||
|
|
self.assertFalse(self.env.ref('foo.bar', raise_if_not_found=False))
|
||
|
|
|
||
|
|
def test_import_zip_ignore_unexpected_data_extension(self):
|
||
|
|
"""Assert data files using an unexpected extensions are correctly ignored"""
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"{'data': ['res.partner.xls']}"),
|
||
|
|
('foo/res.partner.xls',
|
||
|
|
b'"id","name"\n' \
|
||
|
|
b'foo,foo'
|
||
|
|
),
|
||
|
|
]
|
||
|
|
with self.assertLogs('odoo.addons.base_import_module.models.ir_module') as log_catcher:
|
||
|
|
self.import_zipfile(files)
|
||
|
|
self.assertEqual(len(log_catcher.output), 1)
|
||
|
|
self.assertIn('module foo: skip unsupported file res.partner.xls', log_catcher.output[0])
|
||
|
|
self.assertFalse(self.env.ref('foo.foo', raise_if_not_found=False))
|
||
|
|
|
||
|
|
def test_import_zip_extract_only_useful(self):
|
||
|
|
"""Assert only the data and static files are extracted of the ZIP archive during the module import"""
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"{'data': ['data.xml', 'res.partner.xls']}"),
|
||
|
|
('foo/data.xml', b"""
|
||
|
|
<data>
|
||
|
|
<record id="foo" model="res.partner">
|
||
|
|
<field name="name">foo</field>
|
||
|
|
</record>
|
||
|
|
</data>
|
||
|
|
"""),
|
||
|
|
('foo/res.partner.xls',
|
||
|
|
b'"id","name"\n' \
|
||
|
|
b'foo,foo'
|
||
|
|
),
|
||
|
|
('foo/static/css/style.css', b".foo{color: black;}"),
|
||
|
|
('foo/foo.py', b"foo = 42"),
|
||
|
|
]
|
||
|
|
extracted_files = []
|
||
|
|
addons_path = []
|
||
|
|
origin_import_module = type(self.env['ir.module.module'])._import_module
|
||
|
|
def _import_module(self, *args, **kwargs):
|
||
|
|
_module, path = args
|
||
|
|
for root, _dirs, files in os.walk(path):
|
||
|
|
for file in files:
|
||
|
|
extracted_files.append(os.path.relpath(os.path.join(root, file), path))
|
||
|
|
addons_path.extend(__addons_path__)
|
||
|
|
return origin_import_module(self, *args, **kwargs)
|
||
|
|
with patch.object(type(self.env['ir.module.module']), '_import_module', _import_module):
|
||
|
|
self.import_zipfile(files)
|
||
|
|
self.assertIn(
|
||
|
|
'__manifest__.py', extracted_files,
|
||
|
|
"__manifest__.py must be in the extracted files")
|
||
|
|
self.assertIn(
|
||
|
|
'data.xml', extracted_files,
|
||
|
|
"data.xml must be in the extracted files as its in the manifest's data")
|
||
|
|
self.assertIn(
|
||
|
|
'static/css/style.css', extracted_files,
|
||
|
|
"style.css must be in the extracted files as its in the static folder")
|
||
|
|
self.assertNotIn(
|
||
|
|
'res.partner.xls', extracted_files,
|
||
|
|
"res.partner.xls must not be in the extracted files as it uses an unsupported extension of data file")
|
||
|
|
self.assertNotIn(
|
||
|
|
'foo.py', extracted_files,
|
||
|
|
"foo.py must not be in the extracted files as its not the manifest's data")
|
||
|
|
self.assertFalse(
|
||
|
|
set(addons_path).difference(__addons_path__),
|
||
|
|
'No directory must be added in the addons path during import')
|
||
|
|
|
||
|
|
def test_import_and_uninstall_module(self):
|
||
|
|
bundle = 'web.assets_backend'
|
||
|
|
path = '/test_module/static/src/js/test.js'
|
||
|
|
manifest_content = json.dumps({
|
||
|
|
'name': 'Test Module',
|
||
|
|
'description': 'Test',
|
||
|
|
'assets': {
|
||
|
|
'web.assets_backend': [
|
||
|
|
'test_module/static/src/js/test.js'
|
||
|
|
]
|
||
|
|
},
|
||
|
|
'license': 'LGPL-3',
|
||
|
|
'category': 'Test Category',
|
||
|
|
'depends': ['base'],
|
||
|
|
})
|
||
|
|
|
||
|
|
stream = BytesIO()
|
||
|
|
with ZipFile(stream, 'w') as archive:
|
||
|
|
archive.writestr('test_module/__manifest__.py', manifest_content)
|
||
|
|
archive.writestr('test_module/static/src/js/test.js', "console.log('AAA');")
|
||
|
|
|
||
|
|
# Import test module
|
||
|
|
self.env['ir.module.module']._import_zipfile(stream)
|
||
|
|
|
||
|
|
attachment = self.env['ir.attachment'].search([('url', '=', path)])
|
||
|
|
self.assertEqual(attachment.name, 'test.js')
|
||
|
|
self.assertEqual(attachment.type, 'binary')
|
||
|
|
self.assertEqual(attachment.raw, b"console.log('AAA');")
|
||
|
|
|
||
|
|
asset = self.env['ir.asset'].search([('name', '=', f'test_module.{bundle}.{path}')])
|
||
|
|
self.assertEqual(asset.path, path)
|
||
|
|
self.assertEqual(asset.bundle, bundle)
|
||
|
|
self.assertEqual(asset.directive, 'append')
|
||
|
|
self.assertEqual(asset.target, False)
|
||
|
|
|
||
|
|
asset_data = self.env['ir.model.data'].search([('model', '=', 'ir.asset'), ('res_id', '=', asset.id)])
|
||
|
|
self.assertEqual(asset_data.module, 'test_module')
|
||
|
|
self.assertEqual(asset_data.name, f'{bundle}_{path}'.replace(".", "_"))
|
||
|
|
|
||
|
|
module = self.env['ir.module.module'].search([('name', '=', 'test_module')])
|
||
|
|
self.assertEqual(module.dependencies_id.mapped('name'), ['base'])
|
||
|
|
self.assertEqual(module.category_id.name, 'Test Category')
|
||
|
|
|
||
|
|
# Uninstall test module
|
||
|
|
self.env['ir.module.module'].search([('name', '=', 'test_module')]).module_uninstall()
|
||
|
|
|
||
|
|
attachment = self.env['ir.attachment'].search([('url', '=', path)])
|
||
|
|
self.assertEqual(len(attachment), 0)
|
||
|
|
|
||
|
|
asset = self.env['ir.asset'].search([('name', '=', f'test_module.{bundle}.{path}')])
|
||
|
|
self.assertEqual(len(asset), 0)
|
||
|
|
|
||
|
|
asset_data = self.env['ir.model.data'].search([('model', '=', 'ir.asset'), ('res_id', '=', asset.id)])
|
||
|
|
self.assertEqual(len(asset_data), 0)
|
||
|
|
|
||
|
|
def test_import_and_update_module(self):
|
||
|
|
self.test_user = new_test_user(
|
||
|
|
self.env, login='Admin',
|
||
|
|
groups='base.group_user,base.group_system',
|
||
|
|
name='Admin',
|
||
|
|
)
|
||
|
|
bundle = 'web.assets_backend'
|
||
|
|
path = 'test_module/static/src/js/test.js'
|
||
|
|
manifest_content = json.dumps({
|
||
|
|
'name': 'Test Module',
|
||
|
|
'description': 'Test',
|
||
|
|
'assets': {
|
||
|
|
bundle: [
|
||
|
|
path
|
||
|
|
]
|
||
|
|
},
|
||
|
|
'license': 'LGPL-3',
|
||
|
|
'version': '1.0',
|
||
|
|
})
|
||
|
|
stream = BytesIO()
|
||
|
|
with ZipFile(stream, 'w') as archive:
|
||
|
|
archive.writestr('test_module/__manifest__.py', manifest_content)
|
||
|
|
archive.writestr(path, "console.log('AAA');")
|
||
|
|
|
||
|
|
# Import test module
|
||
|
|
self.env['ir.module.module'].with_user(self.test_user)._import_zipfile(stream)
|
||
|
|
|
||
|
|
attachment = self.env['ir.attachment'].search([('url', '=', f'/{path}')])
|
||
|
|
self.assertEqual(attachment.name, 'test.js')
|
||
|
|
self.assertEqual(attachment.type, 'binary')
|
||
|
|
self.assertEqual(attachment.raw, b"console.log('AAA');")
|
||
|
|
|
||
|
|
asset = self.env['ir.asset'].search([('name', '=', f'test_module.{bundle}./{path}')])
|
||
|
|
self.assertEqual(asset.path, f'/{path}')
|
||
|
|
self.assertEqual(asset.bundle, bundle)
|
||
|
|
self.assertEqual(asset.directive, 'append')
|
||
|
|
self.assertEqual(asset.target, False)
|
||
|
|
|
||
|
|
asset_data = self.env['ir.model.data'].search([('model', '=', 'ir.asset'), ('res_id', '=', asset.id)])
|
||
|
|
self.assertEqual(asset_data.module, 'test_module')
|
||
|
|
self.assertEqual(asset_data.name, f'{bundle}_/{path}'.replace(".", "_"))
|
||
|
|
|
||
|
|
module = self.env['ir.module.module'].search([('name', '=', 'test_module')])
|
||
|
|
self.assertEqual(module.latest_version, f'{release.series}.1.0')
|
||
|
|
|
||
|
|
# Update test module
|
||
|
|
stream = BytesIO()
|
||
|
|
with ZipFile(stream, 'w') as archive:
|
||
|
|
archive.writestr('test_module/__manifest__.py', manifest_content)
|
||
|
|
archive.writestr(path, "console.log('BBB');")
|
||
|
|
|
||
|
|
# Import test module
|
||
|
|
self.env['ir.module.module'].with_user(self.test_user)._import_zipfile(stream)
|
||
|
|
|
||
|
|
attachment = self.env['ir.attachment'].search([('url', '=', f'/{path}')])
|
||
|
|
self.assertEqual(attachment.name, 'test.js')
|
||
|
|
self.assertEqual(attachment.type, 'binary')
|
||
|
|
self.assertEqual(attachment.raw, b"console.log('BBB');")
|
||
|
|
|
||
|
|
asset = self.env['ir.asset'].search([('name', '=', f'test_module.{bundle}./{path}')])
|
||
|
|
self.assertEqual(asset.path, f'/{path}')
|
||
|
|
self.assertEqual(asset.bundle, bundle)
|
||
|
|
self.assertEqual(asset.directive, 'append')
|
||
|
|
self.assertEqual(asset.target, False)
|
||
|
|
|
||
|
|
asset_data = self.env['ir.model.data'].search([('model', '=', 'ir.asset'), ('res_id', '=', asset.id)])
|
||
|
|
self.assertEqual(asset_data.module, 'test_module')
|
||
|
|
self.assertEqual(asset_data.name, f'{bundle}_/{path}'.replace(".", "_"))
|
||
|
|
|
||
|
|
|
||
|
|
class TestImportModuleHttp(TestImportModule, odoo.tests.HttpCase):
|
||
|
|
def test_import_module_icon(self):
|
||
|
|
"""Assert import a module with an icon result in the module displaying the icon in the apps menu,
|
||
|
|
and with the base module icon if module without icon"""
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"{'name': 'foo'}"),
|
||
|
|
('foo/static/description/icon.png', b"foo_icon"),
|
||
|
|
('bar/__manifest__.py', b"{'name': 'bar'}"),
|
||
|
|
]
|
||
|
|
self.import_zipfile(files)
|
||
|
|
foo_icon_path, foo_icon_data = files[1]
|
||
|
|
# Assert icon of module foo, which must be the icon provided in the zip
|
||
|
|
self.assertEqual(self.url_open('/' + foo_icon_path).content, foo_icon_data)
|
||
|
|
# Assert icon of module bar, which must be the icon of the base module as none was provided
|
||
|
|
self.assertEqual(self.env.ref('base.module_bar').icon_image, self.env.ref('base.module_base').icon_image)
|
||
|
|
|
||
|
|
def test_import_module_field_file(self):
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"{'data': ['data.xml']}"),
|
||
|
|
('foo/data.xml', b"""
|
||
|
|
<data>
|
||
|
|
<record id="logo" model="ir.attachment">
|
||
|
|
<field name="name">Company Logo</field>
|
||
|
|
<field name="datas" type="base64" file="foo/static/src/img/content/logo.png"/>
|
||
|
|
<field name="res_model">ir.ui.view</field>
|
||
|
|
<field name="public" eval="True"/>
|
||
|
|
</record>
|
||
|
|
</data>
|
||
|
|
"""),
|
||
|
|
('foo/static/src/img/content/logo.png', b"foo_logo"),
|
||
|
|
]
|
||
|
|
self.import_zipfile(files)
|
||
|
|
logo_path, logo_data = files[2]
|
||
|
|
self.assertEqual(base64.b64decode(self.env.ref('foo.logo').datas), logo_data)
|
||
|
|
self.assertEqual(self.url_open('/' + logo_path).content, logo_data)
|
||
|
|
|
||
|
|
def test_import_module_assets_http(self):
|
||
|
|
asset_bundle = 'web_assets_backend'
|
||
|
|
asset_path = '/foo/static/src/js/test.js'
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', json.dumps({
|
||
|
|
'assets': {
|
||
|
|
asset_bundle: [
|
||
|
|
asset_path,
|
||
|
|
]
|
||
|
|
},
|
||
|
|
})),
|
||
|
|
('foo/static/src/js/test.js', b"foo_assets_backend"),
|
||
|
|
]
|
||
|
|
self.import_zipfile(files)
|
||
|
|
asset = self.env.ref('foo.web_assets_backend_/foo/static/src/js/test_js')
|
||
|
|
self.assertEqual(asset.bundle, asset_bundle)
|
||
|
|
self.assertEqual(asset.path, asset_path)
|
||
|
|
asset_data = files[1][1]
|
||
|
|
self.assertEqual(self.url_open(asset_path).content, asset_data)
|
||
|
|
|
||
|
|
def test_check_zip_dependencies(self):
|
||
|
|
files = [
|
||
|
|
('foo/__manifest__.py', b"{'data': ['data.xml']}")
|
||
|
|
]
|
||
|
|
archive = BytesIO()
|
||
|
|
with ZipFile(archive, 'w') as zipf:
|
||
|
|
for path, data in files:
|
||
|
|
zipf.writestr(path, data)
|
||
|
|
modules_dependencies, _not_found = self.env['ir.module.module']._get_missing_dependencies(archive.getvalue())
|
||
|
|
import_module = self.env['base.import.module'].create({
|
||
|
|
'module_file': base64.b64encode(archive.getvalue()),
|
||
|
|
'state': 'init',
|
||
|
|
'modules_dependencies': modules_dependencies,
|
||
|
|
})
|
||
|
|
dependencies_names = import_module.get_dependencies_to_install_names()
|
||
|
|
self.assertEqual(dependencies_names, [])
|